Skip to content

[Shopify] Variant option extensibility #6013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JesperSchulz merged 1 commit into from
Jan 19, 2026
Merged

[Shopify] Variant option extensibility #6013

JesperSchulz merged 1 commit into from
Jan 19, 2026
+29 −0

Conversation

@tVisionDeb
Copy link
Contributor

@tVisionDeb tVisionDeb commented Jan 2, 2026 •
edited by github-actions bot
Loading

Fixes #5867

Shopify Connector: Custom Variant Naming for Item Variants

BC Idea: https://experience.dynamics.com/ideas/idea/?ideaid=244315e3-d8bb-f011-aa43-7c1e52a6c1f4

Adds logic to recalculate and set custom variant names after standard data fill-in, using a new event (OnAfterFillInProductVariantDataFromVariant).

Fixes AB#617325

@tVisionDeb tVisionDeb requested a review from a team as a code owner January 2, 2026 14:47
@github-actions github-actions bot added AL: Apps (W1) Add-on apps for W1 From Fork Pull request is coming from a fork labels Jan 2, 2026
@onbuyuka onbuyuka added the Linked Issue is linked to a Azure Boards work item label Jan 5, 2026
@onbuyuka onbuyuka changed the title Fixes #5867 [Shopify] Variant option extensibility Jan 5, 2026
@github-actions github-actions bot added this to the Version 28.0 milestone Jan 5, 2026
onbuyuka
onbuyuka previously approved these changes Jan 5, 2026
View reviewed changes
@onbuyuka onbuyuka enabled auto-merge (squash) January 5, 2026 10:59
@onbuyuka
Copy link
Contributor

onbuyuka commented Jan 6, 2026

@tVisionDeb build fails due to compilation errors:

  Compilation started for project 'Shopify Connector' containing '624' files at '11:43:49.466'.
  
  Error: AL0161 'OnAfterFillInProductVariantDataFromVariant(var Record "Shpfy Variant", Record Item, Record "Item Variant", Record "Item Unit of Measure", Record "Shpfy Shop")' is inaccessible due to its protection level
  Error: AL0118 The name 'ItemUnitofMeasure' does not exist in the current context.
  Error: AL0161 'OnAfterFillInProductVariantDataFromVariant(var Record "Shpfy Variant", Record Item, Record "Item Variant", Record "Item Unit of Measure", Record "Shpfy Shop")' is inaccessible due to its protection level

@JesperSchulz JesperSchulz added the Integration GitHub request for Integration area label Jan 6, 2026
JesperSchulz
JesperSchulz previously approved these changes Jan 6, 2026
View reviewed changes
auto-merge was automatically disabled January 16, 2026 15:39

Head branch was pushed to by a user without write access

@tVisionDeb tVisionDeb dismissed stale reviews from JesperSchulz and onbuyuka via 4c509f9 January 16, 2026 15:39
@tVisionDeb tVisionDeb force-pushed the feature/5867-shopify-event branch from 4c509f9 to add5155 Compare January 16, 2026 15:41
@JesperSchulz JesperSchulz enabled auto-merge (squash) January 19, 2026 12:24
@JesperSchulz JesperSchulz merged commit 40d1fcb into microsoft:main Jan 19, 2026
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JesperSchulz JesperSchulz JesperSchulz approved these changes

@onbuyuka onbuyuka onbuyuka approved these changes

Assignees

@onbuyuka onbuyuka

Labels

AL: Apps (W1) Add-on apps for W1 From Fork Pull request is coming from a fork Integration GitHub request for Integration area Linked Issue is linked to a Azure Boards work item

Projects

None yet

Milestone

Version 28.0

Development

Successfully merging this pull request may close these issues.

[BC Idea]: OnAfterFillInProductVariantDataFromVariant event in Shopify connector

3 participants

@tVisionDeb @onbuyuka @JesperSchulz